Decouple MessageRouter from Router
#3326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3326 +/- ##
==========================================
- Coverage 89.64% 89.63% -0.01%
==========================================
Files 126 126
Lines 102676 102657 -19
Branches 102676 102657 -19
==========================================
- Hits 92043 92020 -23
+ Misses 7909 7907 -2
- Partials 2724 2730 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ChannelManager is parameterized by a Router, which must also implement MessageRouter. Instead, add a MessageRouter parameter such that the Router and MessageRouter traits can be de-coupled. This simplifies using something other than DefaultMessageRouter, which DefaultRouter currently delegates to.
DefaultRouter::create_blinded_payment_paths may creat a one-hop blinded path with the recipient as the introduction node. Update the privacy section of DefaultRouter's docs to indicate this as is done in the docs for DefaultMessageRouter.
Now that ChannelManager is parameterized by both a MessageRouter and a Router, Router implementations no longer need to implement MessageRouter, too.
jkczyz
force-pushed
the
2024-09-split-router
branch
from
a8e08d2 to
cad0985
Compare
shaavan
approved these changes
Sep 23, 2024
Comment on lines
1365
to
+1366
| /// - [`Router`] for finding payment paths when initiating and retrying payments | ||
| /// - [`MessageRouter`] for finding message paths when initiating and retrying onion messages |
There was a problem hiding this comment.
Now that Router, and MessageRouter are decoupled, should we consider renaming Router to PaymentRouter?
There was a problem hiding this comment.
Yeah I think this should be considered in a follow-up PR at least. Makes sense.
dunxen
approved these changes
Sep 24, 2024
Comment on lines
1365
to
+1366
| /// - [`Router`] for finding payment paths when initiating and retrying payments | ||
| /// - [`MessageRouter`] for finding message paths when initiating and retrying onion messages |
There was a problem hiding this comment.
Yeah I think this should be considered in a follow-up PR at least. Makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChannelManageris parameterized by aRouter, which must also implementMessageRouter. Instead, add aMessageRouterparameter such that theRouterandMessageRoutertraits can be de-coupled. This simplifies using something other thanDefaultMessageRouter, whichDefaultRoutercurrently delegates to.